Skip to content

arch(navigation): migrate Preferences & Statistics to Navigation#21257

Merged
david-allison merged 4 commits into
ankidroid:mainfrom
david-allison:navigation
Jun 22, 2026
Merged

arch(navigation): migrate Preferences & Statistics to Navigation#21257
david-allison merged 4 commits into
ankidroid:mainfrom
david-allison:navigation

Conversation

@david-allison

Copy link
Copy Markdown
Member

Note

Assisted-by: Claude Opus 4.8

Purpose / Description

Removes another need for cross-feature module dependencies

Fixes

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison changed the title arch(navigation): migrate Preferences to Navigation arch(navigation): migrate Preferences & Statistics to Navigation Jun 11, 2026
@david-allison david-allison added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jun 20, 2026
@david-allison david-allison force-pushed the navigation branch 3 times, most recently from 47e027c to 8d2b3af Compare June 20, 2026 13:48
Removes another need for cross-feature module dependencies

Related to 20558
Part of 20737

Assisted-by: Claude Opus 4.8
Removes another need for cross-feature module dependencies

Related to 20558
Part of 20737

Assisted-by: Claude Fable 5
For a navigation-related helper, simplifying:
ActivityScenrio.launch(destination)

Assisted-by: Claude Opus 4.8
Since we have a `DeferredNavigation` in RobolectricTest, this can be
simplified

Assisted-by: Claude Opus 4.8
@david-allison

Copy link
Copy Markdown
Member Author

low-risk, I'll take responsibility for issues

@david-allison david-allison merged commit 87c7b6b into ankidroid:main Jun 22, 2026
21 checks passed
@david-allison david-allison deleted the navigation branch June 22, 2026 00:39
@github-actions github-actions Bot added this to the 2.25 release milestone Jun 22, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant