Fix CI pipeline: MSRV 1.82, doctest failures, clippy errors#18
Draft
Copilot wants to merge 7 commits into
Draft
Conversation
- Pin idna_adapter to 1.1.0 (unicode-rs backend) to support older Rust versions - Add Cargo.lock to git tracking for reproducible builds - Fix test isolation for env var tests using mutex and RAII guard - Fix MSRV workflow to use correct Rust version format (1.70.0 instead of 1.70) - Apply cargo fmt formatting Co-authored-by: animeshkundu <7248674+animeshkundu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate and resolve CI/CD pipeline failures
Fix MSRV and test isolation issues in CI pipeline
Jan 21, 2026
…lity - Remove unused import 'Write' from src/ui/colors.rs - Remove unused import 'clap::Parser' from src/main.rs - Add #[allow(dead_code)] for unused function extract_typo_from_output - Fix doc list item overindentation in command.rs - Use strip_prefix() instead of manual slicing in git/support.rs and typo.rs - Add #[allow(clippy::vec_init_then_push)] for rules registry - Add #[allow(clippy::type_complexity)] for SHELLS static - Downgrade Cargo.lock from version 4 to version 3 for MSRV compatibility - Apply cargo fmt formatting fixes Co-authored-by: animeshkundu <7248674+animeshkundu@users.noreply.github.com>
Add #[cfg(windows)] attribute to std::env import in powershell.rs to fix compilation on both Linux (clippy) and Windows targets. Co-authored-by: animeshkundu <7248674+animeshkundu@users.noreply.github.com>
Copilot
AI
changed the title
Fix MSRV and test isolation issues in CI pipeline
Fix CI pipeline failures: Cargo.lock v3 compatibility and clippy errors
Jan 21, 2026
- Fix which() doctest to use .to_string() for String parameter - Fix get_output() doctest to wrap in fn main() returning Result - Fix NoSuchFile doctest to use proper mv error message format - Fix FixFile doctest to use FixFile::new() instead of unit struct syntax Co-authored-by: animeshkundu <7248674+animeshkundu@users.noreply.github.com>
- Update MSRV from 1.70 to 1.74 (required by clap 4.5) - Pin home crate to v0.5.9 (v0.5.11+ requires Rust 1.81+) - Add rust-version = "1.74" to Cargo.toml for explicit MSRV declaration - Ensure Cargo.lock stays at version 3 for MSRV compatibility Co-authored-by: animeshkundu <7248674+animeshkundu@users.noreply.github.com>
Production dependency chain requires Rust 1.82+: - oops -> toml -> toml_edit -> indexmap 2.13 (requires Rust 1.82) This is the minimum realistic MSRV given current dependencies. The home crate remains pinned at v0.5.9 in Cargo.lock. Co-authored-by: animeshkundu <7248674+animeshkundu@users.noreply.github.com>
Copilot
AI
changed the title
Fix CI pipeline failures: Cargo.lock v3 compatibility and clippy errors
Fix CI pipeline: MSRV 1.82, doctest failures, clippy errors
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failing on 7/10 jobs due to MSRV incompatibility and doctest compilation errors.
MSRV Update: 1.70 → 1.82
Production dependency chain requires Rust 1.82:
rust-version = "1.82"to Cargo.tomldtolnay/rust-toolchain@1.82.0hometo v0.5.9 in Cargo.lock (v0.5.11+ requires Rust 1.86)Doctest Fixes
which(): Parameter expectsString, not&strget_output(): Missingfn main() -> Result<...>wrapper for?operatorNoSuchFile: Doctest error message didn't match regex patternsFixFile: Struct has fields, requires::new()not unit syntaxClippy Fixes
Write,clap::Parser)#[cfg(windows)]onstd::envimport for cross-platform compilationstrip_prefix()instead of manual slicing#[allow]for intentional patterns (vec_init_then_push,type_complexity)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.