chore(deps-dev): bump @playwright/test from 1.61.0 to 1.61.1 in /superset-frontend#113
Open
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
…rset-frontend Co-Authored-By: bot_apk <apk@cognition.ai>
TablePreview: use accessible labels ('Refresh table schema',
'Show CREATE VIEW statement') instead of icon names ('sync', 'eye'),
and remove unused IconTooltip mock since the component uses ActionButton.
SavedQueryList: disambiguate the '+ Query' button selector from the
'Query preview' action button by matching 'plus.*query' instead of
the bare /query/i regex.
Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The accessible name of ActionButton varies across environments (icon aria-label vs tooltip aria-label). Use the stable data-test attribute instead of getByRole with accessible names. Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Re-applies the Dependabot bump of
@playwright/testfrom 1.61.0 → 1.61.1 (tracking apache/superset#41616) and fixes the two failing jest shards (sharded-jest-tests (5)andsharded-jest-tests (7)).Fixes #111
Dependency bump:
superset-frontend/package.jsonand lockfile updated.Test fixes:
TablePreview.test.tsx: The component usesActionButtonwhich setsdata-test={label}. The previous test usedgetByRole('button', { name: 'sync' })/{ name: 'eye' }to find buttons by icon name, but the accessible name computation varies depending on whether the wrapping Tooltip injectsaria-label. Switched togetByTestId('Refresh table schema')/getByTestId('Show CREATE VIEW statement')which matches the stabledata-testattribute. Also removed the staleIconTooltipmock.SavedQueryList.test.tsx:findByRole('button', { name: /query/i })matched both the "+ Query" button (accessible name"plus Query") and the "Query preview" action button. Changed to/plus.*query/ito disambiguate.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — no UI changes.
TESTING INSTRUCTIONS
CI should pass
sharded-jest-testsshards 5 and 7.ADDITIONAL INFORMATION
Link to Devin session: https://app.devin.ai/sessions/98391997ffaa4db98b06f4917cf99f8a