chore(deps): add lodash-es ^4.18.1 to plugin-chart-handlebars#107
Open
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Add lodash-es as a direct dependency and migrate imports from lodash to lodash-es in plugin-chart-handlebars for tree-shaking support. Tracks apache#41560 Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Re-applies the lodash-es bump from upstream apache/superset#41560 on this fork.
Changes:
lodash-es: ^4.18.1as a direct dependency inplugin-chart-handlebars/package.json@types/lodash-es: ^4.17.12as a devDependency for TypeScript declarationslodash→lodash-esfor tree-shaking:HandlebarsViewer.tsx:isPlainObjectconsts.ts:debounceorderBy.tsx:isEmptypackage-lock.jsonAll 6 handlebars plugin test suites (20 tests) pass locally.
npm run plugins:build(validate-frontend) passes.Fixes #90
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — no UI changes.
TESTING INSTRUCTIONS
cd superset-frontend && npm cinpx jest --testPathPatterns="plugins/plugin-chart-handlebars" --no-coverage— all 6 suites should pass.npm run plugins:build— should complete without TS errors.ADDITIONAL INFORMATION
Link to Devin session: https://app.devin.ai/sessions/1b8c85d6e8f84492a473207742f6d8ea