chore(deps): update lodash-es requirement from ^4.17.21 to ^4.18.1 in plugin-chart-word-cloud#100
Open
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
… plugin-chart-word-cloud - Migrate lodash imports to lodash-es in plugin-chart-word-cloud - Add lodash-es ^4.18.1 as explicit dependency - Fix TablePreview test: replace stale IconTooltip mock with data-test queries - Fix SavedQueryList test: use specific selector to avoid multiple matches Co-Authored-By: bot_apk <apk@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The plugin build requires @types/lodash-es to provide TypeScript declarations for lodash-es imports. This was added to the upstream root package.json as part of the lodash→lodash-es migration. Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-applies the stuck Dependabot bump (apache#41561) for
lodash-es^4.17.21 → ^4.18.1 insuperset-frontend/plugins/plugin-chart-word-cloud, plus fixes for the two failing jest shards (5 and 7).Dependency changes:
plugin-chart-word-cloud/package.json: add"lodash-es": "^4.18.1"as explicit dependencyimport { isEqual } from 'lodash'→'lodash-es'inWordCloud.tsx,import { sortBy } from 'lodash'→'lodash-es'inColorSchemeControl/index.tsxTest fixes (unrelated to version bump, but blocking CI on the upstream PR):
TablePreview.test.tsx: Remove staleIconTooltipmock (component now usesActionButton); replacegetByRole('button', { name: 'sync'/'eye' })withfindByTestId('Refresh table schema')/findByTestId('Show CREATE VIEW statement')to match current renderingSavedQueryList.test.tsx: Narrow selector from/query/ito/Query$/to avoid matching row-actionActionButtons whosearia-label(e.g. "Query preview") also contains "query"Tracking issue: #91
Link to Devin session: https://app.devin.ai/sessions/a5b7db68e6cc4ff99a13fe8465805be9