Skip to content

Update release to version 3.0.0#98

Merged
lip-liu merged 2 commits into
mainfrom
rls-3-update
Jun 22, 2026
Merged

Update release to version 3.0.0#98
lip-liu merged 2 commits into
mainfrom
rls-3-update

Conversation

@lip-liu

@lip-liu lip-liu commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the BetoCQ test suite to version 3.0.0, migrating tests to a new performance test framework, renaming the main test suite script to betocq_onboarding_test_suite, and adding a commented-out PyPI upload command in build.sh. Feedback includes correcting a typo in the changelog and replacing the commented-out PyPI upload command with an environment-variable-driven conditional block to prevent manual editing errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

### New
* Migrate the tests to the new performance test framework
### Bug fixes
* Fix the issue for testing 2G only devcies

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the changelog: 'devcies' should be 'devices'.

Suggested change
* Fix the issue for testing 2G only devcies
* Fix the issue for testing 2G only devices

Comment thread build.sh
Comment on lines +38 to +39
# uncomment to release to pypi
# twine upload --repository-url https://us-python.pkg.dev/oss-exit-gate-prod/betocq--pypi dist/*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of using commented-out code that requires manual editing (uncommenting/commenting) during a release, which is error-prone and can lead to accidental commits of uncommented lines, consider using an environment variable to conditionally trigger the PyPI upload.

Suggested change
# uncomment to release to pypi
# twine upload --repository-url https://us-python.pkg.dev/oss-exit-gate-prod/betocq--pypi dist/*
if [ "${RELEASE_TO_PYPI}" = "true" ]; then
twine upload --repository-url https://us-python.pkg.dev/oss-exit-gate-prod/betocq--pypi dist/*
fi

@lip-liu lip-liu merged commit 93fa65b into main Jun 22, 2026
7 checks passed
@lip-liu lip-liu deleted the rls-3-update branch June 22, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants