Sync changes from internal dev branch.

[lip-liu]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @lip-liu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates substantial updates from an internal development branch, primarily focusing on a significant overhaul of the project's underlying build and packaging infrastructure. Concurrently, it introduces new testing capabilities to assess Nearby Connections performance under specific network conditions, enhancing the suite's coverage for complex multi-device interactions.

Highlights

• Build System Overhaul: The pull request removes several core build and packaging configuration files, including build.sh, MANIFEST.in, and pyproject.toml. This indicates a significant restructuring or replacement of the project's build and packaging process, likely streamlining or updating it to a new standard.
• New Nearby Connections Performance Test: A new performance test, nc_multi_advertisers_test.py, has been added. This test focuses on evaluating Nearby Connections performance in scenarios where multiple advertisers are present, specifically using BLE for advertising and discovery, and measures connection establishment times.
• Removal of Old Changelog and iPerf Utilities Test: The CHANGELOG.md file, which tracked the release history of the BetoCQ test suite, has been removed. Additionally, iperf_utils_test.py, containing unit tests for iPerf utilities, has also been removed, suggesting a refactoring or deprecation of the associated iPerf utility code or its testing approach.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request syncs changes from an internal development branch, which includes removing several build and configuration files, and adding a new performance test for Nearby Connections with multiple advertisers. My review focuses on the new test file. I've identified a high-severity issue in the test's teardown logic that could lead to a crash and mask other failures, an unnecessary operation that consumes device resources, and a point of poor encapsulation that affects maintainability. I've provided suggestions to fix the crash and improve the code.

I am having trouble creating individual review comments. Click here to see my feedback.

betocq/performance_tests/nc_multi_advertisers_test.py (216-228)

There's a potential for a ZeroDivisionError if self._test_count is 0, which can happen if all test iterations fail before the counter is incremented. Similarly, max(), min(), and statistics.median() will raise exceptions if self._connection_time_list is empty.

This can cause teardown_class to crash, which might hide the root cause of the actual test failures. It's safer to check if there are any results before trying to calculate and record statistics.

    if self._test_count > 0:
      self.record_data({
          'Test Class': self.TAG,
          'properties': {
              'avg_connection_time (sec)': (
                  self._sum_connection_time_sec / self._test_count
              ),
              'max_connection_time (sec)': max(self._connection_time_list),
              'median_connection_time (sec)': statistics.median(
                  self._connection_time_list
              ),
              'min_connection_time (sec)': min(self._connection_time_list),
          },
      })

betocq/performance_tests/nc_multi_advertisers_test.py (94-98)

Discovery is being started on all advertiser devices, but the returned callback handlers are never used. This appears to be unnecessary and consumes device resources (CPU, battery, and radio time). If this is intended to create a more realistic, noisy environment, it should be documented with a comment. Otherwise, this block of code should be removed.

betocq/performance_tests/nc_multi_advertisers_test.py (135-138)

Accessing private members (_advertiser_connection_lifecycle_callback and _advertiser_endpoint_id) of the nearby_connection_wrapper object violates encapsulation principles. This makes the code brittle, as future changes to the NearbyConnectionWrapper class could break this test.

A better approach would be to refactor NearbyConnectionWrapper to expose a public API that supports this use case (where discovery is performed externally). For now, this can be considered technical debt, but it should be addressed to improve maintainability.