test: narrow error-path gaps for combineAbortSignals and response validation truncation#118
Merged
Merged
Conversation
Owner
Author
|
Reviewed. I do not see any blocking issues here. The only production change is exporting Verified locally on
Minor non-blocking thought: if we want to keep the internal boundary extra explicit, we could later annotate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combineAbortSignalsfromrequestTimeout.ts(internal-only, not re-exported fromsrc/index.ts) to allow direct unit testingtest/requestTimeout.combineAbortSignals.test.tscovering all 7 branches: no upstream signal, pre-aborted timeout, pre-aborted upstream, timeout fires, upstream fires, cleanup removes listeners, no double-aborttest/responseValidation.truncation.test.tscovering truncation to 3 issues, path-prefixed vs. root-level formatting, valid payload passthrough, and endpoint propagation in error detailsTest plan
npx vitest run— all tests pass (422 → 422, 0 failures)npx tsc --noEmit— no type errorsGenerated by Claude Code