fix: PE case-insensitive extensions (Win32/ISO 9660 compatibility)#4996
Open
activeobd wants to merge 1 commit into
Open
fix: PE case-insensitive extensions (Win32/ISO 9660 compatibility)#4996activeobd wants to merge 1 commit into
activeobd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pe-binary-package-cataloger skips valid PE files with upper-case extensions owing to the way FiletreeResolver glob pattern match works: while .EXE and .DLL are perfectly valid from Win32 standpoint, syft skips scanning them entirely. The problem is particularly noticeable when scanning regular ISO 9660 images of dependency installers, where file names/extensions are uppercase.
The PR adds only new extensions (.EXE and .DLL) to the search criteria without reducing the existing coverage.
Type of change
Checklist
Issue references