fix: use printf instead of echo to fix ANSI color output#4978
Open
Jouini-Mohamed-Chaker wants to merge 1 commit into
Open
fix: use printf instead of echo to fix ANSI color output#4978Jouini-Mohamed-Chaker wants to merge 1 commit into
Jouini-Mohamed-Chaker wants to merge 1 commit into
Conversation
Signed-off-by: Jouini Mohamed Chaker <JouiniMohamedChaker@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the
install.shscript leaks raw ANSI escape codes (e.g.,\033[0;31m) into the terminal output when executed via strict POSIXsh(such asdash).The
echocommand does not natively evaluate ANSI color codes in these environments. This update refactors theecho_stderrandlog_tagfunctions to useprintf "%b"instead ofecho. This ensures cross-shell compatibility and renders the terminal colors correctly regardless of the shell being used.CLI Output Changes:
Before:

After:

Type of change
Checklist