Read docker host/socket location from the current docker context#193
Closed
vmasutin wants to merge 3 commits into
Closed
Read docker host/socket location from the current docker context#193vmasutin wants to merge 3 commits into
vmasutin wants to merge 3 commits into
Conversation
…ntext Resolves issues with lima/colima/docker desktop (they all have one thing in common dockerd sockets are in custom locations) Signed-off-by: Valery Masiutsin <val.masutin@gmail.com>
vmasutin
changed the title
Signed-off-by: Valery Masiutsin <val.masutin@gmail.com>
vmasutin
force-pushed
the
read-default-docker-context
branch
from
e02725b to
fcd1803
Compare
Author
|
closed in favour of New PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading dockerd socket/host location from the current docker context
It resolves the issues with lima/colima/docker desktop set ups.
This PR probably needs more work (tests, style, etc), I will appreciate the comments.
Parts of the code are coming from https://github.com/docker/cli repo.
Changes were tested with syft and local lima setup on MacOS.