Fix: channel.get() does not yield errors to the callback (#832)#848
Merged
Conversation
When the server closed the channel in response to a BasicGet (e.g. queue
not found), the callback API silently dropped the error and the promise
API rejected with a raw close frame rather than a proper Error instance.
Extracts a shared convertCloseFrameToError helper from _rpc and uses it
in both get() implementations so errors are consistently surfaced as
Error objects with .code, .classId and .methodId properties.
Adds a focused describe('get') block to the promise API tests covering
the empty queue, message present, and queue-not-found cases.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convertCloseFrameToErrorhelper from_rpcinchannel.jscallback_model.jsget()which silently dropped close frame errors, never invoking the callbackchannel_model.jsget()which rejected with a raw close frame object rather than a properErrorinstancedescribe('get')block to the promise API tests covering empty queue, message present, and queue-not-found casesCloses #832
🤖 Generated with Claude Code