Embed TypeScript type definitions into the package (#843)#847
Merged
Conversation
Adds bundled .d.ts files so TypeScript users get types automatically on install without needing @types/amqplib. Includes type-level tests and typecheck step in CI and pre-commit hook. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cressie176
force-pushed
the
feat/bundled-types
branch
from
5ae6b55 to
0d3fe2c
Compare
… types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…terfaces Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
More specific overloads must precede general ones in TypeScript — move the
recovery overload before the plain SocketOptions overload so it is correctly
selected when a user passes { recovery: ... } inline.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.d.tsfiles (index.d.ts,callback_api.d.ts,lib/properties.d.ts) so TypeScript users get types automatically on install without needing@types/amqplib"types"and"exports"fields topackage.jsonfor correct type resolutionassertQueuequeue name is now optional,Connectionno longer exposes internal fields,Options.ConnectgainschannelMaxandcredentials,Options.AssertQueuegainsoverflowandqueueMode,createChannel/createConfirmChannelaccept optionalChannelOptions, andIllegalOperationErroris now exportedtypes/verified bytsc --noEmittypecheckscript wired into CI and pre-commit hookCloses #843
🤖 Generated with Claude Code