Fix: ConfirmChannel callbacks silently dropped on close when some publishes had no callback#846
Merged
Merged
Conversation
…blishes had no callback pushConfirmCallback stores `false` for publishes with no callback. The close event drain used `while (cb)` which stops at the first `false`, silently dropping any callbacks queued after it. Fixed by iterating the full array and filtering out called entries afterwards. Also tidied waitForConfirms: use the local `unconfirmed` reference consistently, and rename `val` to `cb` for clarity. Fixes #191 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #191
pushConfirmCallbackstoresfalsefor publishes with no callback (i.e. when usingwaitForConfirmsinstead of per-message callbacks). Thecloseevent drain usedwhile (cb)which stops at the firstfalseentry, silently dropping all callbacks queued after it.Fixed by iterating the full array in the
closehandler, calling real callbacks, then filtering out called entries sowaitForConfirmscan still wrap the remainingfalseslots into rejecting promises.Also tidied
waitForConfirms: use the localunconfirmedreference consistently, and renamevaltocbfor clarity.🤖 Generated with Claude Code