Skip to content

Refactor Statistics System to Activity Hierarchy#132

Open
amorris13 wants to merge 1 commit into
masterfrom
refactor-statistics-structure-4729235028960150680
Open

Refactor Statistics System to Activity Hierarchy#132
amorris13 wants to merge 1 commit into
masterfrom
refactor-statistics-structure-4729235028960150680

Conversation

@amorris13

Copy link
Copy Markdown
Owner

This refactoring simplifies the unnecessarily complicated fragment-based statistics structure by introducing a clean Activity-based hierarchy. It reduces technical debt by removing several obsolete classes and standardizing the navigation logic.


PR created automatically by Jules for task 4729235028960150680 started by @amorris13

Simplified the class structure for statistics by replacing the fragment-based approach with an activity-based hierarchy.

Changes include:
- Created abstract `BaseStatisticsActivity` to handle shared menus and lifecycle.
- Created intermediate `BaseStatisticsListActivity` for list-based statistics (Classic and Arcade).
- Implemented concrete `ClassicStatisticsActivity`, `ArcadeStatisticsActivity`, and `DailyStatisticsActivity`.
- Updated `MainActivity` and `BaseGameActivity` to use explicit intents for the new activities.
- Updated `AndroidManifest.xml` with the new activity definitions.
- Removed legacy `StatisticsActivity`, `BaseGameListFragment`, `BaseStatisticsFragment`, and specific fragment implementations.
- Updated unit tests (`NavigationTest`, `ColoringTest`) to reflect the new architecture.
- Verified that all tests pass.

Co-authored-by: amorris13 <4523811+amorris13@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant