Skip to content

Fix XML syntax error in groupChrPr closing tags #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prashanthjaganathan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix XML syntax error in groupChrPr closing tags #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mathml2omml/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ def to_str(self):
'<m:groupChrPr>'
'<m:chr m:val="%s"/>'
'<m:pos m:val="bot"/>'
'</m:groupChr>'
'</m:groupChrPr>'
'%s'
'</m:groupChr>') % (underscript.escape_text(), base)
return ('<m:limLow>'
Expand Down Expand Up @@ -784,7 +784,7 @@ def to_str(self):
'<m:groupChrPr>'
'<m:chr m:val="%s"/>'
'<m:pos m:val="top"/>'
'</m:groupChr>'
'</m:groupChrPr>'
'%s'
'</m:groupChr>') % (overscript.escape_text(), base)
return ('<m:limUpp>'
Expand Down
22 changes: 22 additions & 0 deletions tests/test_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,3 +234,25 @@ def test_matrix1(self):
'</m:e></m:box></m:e>'
'</m:mr>'
'</m:m></m:e></m:box></m:oMath>')

def test_vector_operator(self):
"""Test for vector operator (GitHub issue #2)"""
mathml = '<math><mover><mi>AB</mi><mo stretchy="true" accent="true">→</mo></mover></math>'

result = mathml2omml.convert(mathml)
print(result)
# The result should contain properly closed groupChrPr tags
self.assertIn('</m:groupChrPr>', result)
self.assertIn('<m:groupChr>', result)
self.assertIn('</m:groupChr>', result)

def test_underscript_accent(self):
"""Test for underscript with stretchy accent (GitHub issue #2)"""
mathml = '<math><munder><mi>AB</mi><mo stretchy="true" accent="true">_</mo></munder></math>'

result = mathml2omml.convert(mathml)

# The result should contain properly closed groupChrPr tags
self.assertIn('</m:groupChrPr>', result)
self.assertIn('<m:groupChr>', result)
self.assertIn('</m:groupChr>', result)