Skip to content

7.x minor updates #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonhebert merged 2 commits into from
Jun 19, 2025
Merged

7.x minor updates #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7092b80
Update GitHub test-suite to use Ubuntu-22.04
jasonhebert Jun 19, 2025
85ea798
Make implicitly null param explicitly null
jasonhebert Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
static-analyze:
name: "Static Analyze"

runs-on: "ubuntu-20.04"
runs-on: "ubuntu-22.04"

steps:
- name: "Checkout"
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
php-version:
- "8.2"
operating-system:
- "ubuntu-20.04"
- "ubuntu-22.04"

steps:
- name: "Checkout"
Expand Down
2 changes: 1 addition & 1 deletion src/AmazonPHP/SellingPartner/Configuration/LoggerConfiguration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public function enableAPIOperation(string $api, string $operation) : self
return $this;
}

public function isSkipped(string $api, string $operation = null) : bool
public function isSkipped(string $api, string|null $operation = null) : bool
{
if (\in_array($api, $this->skippedAPIs, true)) {
return true;
Expand Down
Loading