Code fix perform code refactoring#38
Merged
Merged
Conversation
Reviewer's GuideRefactors configuration management into a single application.yaml, centralizes token creation logic in JwtService, adjusts activation URL composition, and adds Docker/Docker Compose support for running the IAM service with MongoDB and RabbitMQ. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Closed
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The configuration refactor removes the separate
application-*.yamlfiles and hardcodesspring.profiles.active: localwhile introducing adockerprofile in docker-compose; verify that the desired profile is selected in all environments and that equivalent settings from the deleted files are still available where needed. - The new
application-docker.txtandapplication-local.txtfiles will not be picked up as Spring Boot configuration sources; if these are meant to define profile-specific configs they should use a supported format and naming (e.g.,application-docker.yamlor.properties). - The docker-compose service for
iam-servicerelies onMONGO_URI,RABBITMQ_HOST,RABBITMQ_PORT, etc. but does not set them, so the container may fail to start unless these variables are guaranteed to be provided from the environment; consider wiring them explicitly indocker-compose.ymlor documenting the expectation.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The configuration refactor removes the separate `application-*.yaml` files and hardcodes `spring.profiles.active: local` while introducing a `docker` profile in docker-compose; verify that the desired profile is selected in all environments and that equivalent settings from the deleted files are still available where needed.
- The new `application-docker.txt` and `application-local.txt` files will not be picked up as Spring Boot configuration sources; if these are meant to define profile-specific configs they should use a supported format and naming (e.g., `application-docker.yaml` or `.properties`).
- The docker-compose service for `iam-service` relies on `MONGO_URI`, `RABBITMQ_HOST`, `RABBITMQ_PORT`, etc. but does not set them, so the container may fail to start unless these variables are guaranteed to be provided from the environment; consider wiring them explicitly in `docker-compose.yml` or documenting the expectation.
## Individual Comments
### Comment 1
<location path="src/main/resources/application.yaml" line_range="46-47" />
<code_context>
- header: X-Trace-Id
- key: traceId
-
-server:
- port: 4200
-
-logging:
</code_context>
<issue_to_address>
**issue (bug_risk):** Server port and base URL / CORS configuration look inconsistent and may cause confusion or misrouting.
The backend is set to run on port 4200, while `app.base-url` points to `http://localhost:5600/api/v1/auth` and CORS allows `http://localhost:4200`. If 4200 is for the Angular UI and another port is for this API, consider aligning `server.port`, `app.base-url`, and `iam.security.cors.allowed_origins` to match the intended deployment, so it’s clear which port actually serves the API in local/docker setups.
</issue_to_address>
### Comment 2
<location path="docker-compose.yml" line_range="14-15" />
<code_context>
+ dockerfile: Dockerfile
+ ports:
+ - "4200:4200"
+ environment:
+ - SPRING_PROFILES_ACTIVE=docker
+ depends_on:
+ mongo-db:
</code_context>
<issue_to_address>
**issue (bug_risk):** Docker compose does not set the env vars referenced in `application.yaml`, which may break connectivity inside containers.
`application.yaml` expects `${MONGO_URI}`, `${RABBITMQ_HOST}`, `${RABBITMQ_PORT}`, `${RABBITMQ_USER}`, and `${RABBITMQ_PASS}`, but `iam-service`’s compose config only sets `SPRING_PROFILES_ACTIVE`. Unless these vars are injected externally, MongoDB/RabbitMQ connections will fail under `docker-compose`. Please add the relevant env vars here (e.g., using `mongo-db` / `rabbitmq` as hosts) so the compose stack works out of the box.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+46
to
+47
| server: | ||
| port: 4200 |
There was a problem hiding this comment.
issue (bug_risk): Server port and base URL / CORS configuration look inconsistent and may cause confusion or misrouting.
The backend is set to run on port 4200, while app.base-url points to http://localhost:5600/api/v1/auth and CORS allows http://localhost:4200. If 4200 is for the Angular UI and another port is for this API, consider aligning server.port, app.base-url, and iam.security.cors.allowed_origins to match the intended deployment, so it’s clear which port actually serves the API in local/docker setups.
Comment on lines
+14
to
+15
| environment: | ||
| - SPRING_PROFILES_ACTIVE=docker |
There was a problem hiding this comment.
issue (bug_risk): Docker compose does not set the env vars referenced in application.yaml, which may break connectivity inside containers.
application.yaml expects ${MONGO_URI}, ${RABBITMQ_HOST}, ${RABBITMQ_PORT}, ${RABBITMQ_USER}, and ${RABBITMQ_PASS}, but iam-service’s compose config only sets SPRING_PROFILES_ACTIVE. Unless these vars are injected externally, MongoDB/RabbitMQ connections will fail under docker-compose. Please add the relevant env vars here (e.g., using mongo-db / rabbitmq as hosts) so the compose stack works out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce containerization and consolidate configuration for the IAM service while centralizing token generation logic.
New Features:
Enhancements:
Build:
Deployment: