Skip to content

Added user updation of document#32

Merged
amanfoundongithub merged 1 commit into
mainfrom
f-add-Loan-officer
Jun 12, 2026
Merged

Added user updation of document#32
amanfoundongithub merged 1 commit into
mainfrom
f-add-Loan-officer

Conversation

@amanfoundongithub

@amanfoundongithub amanfoundongithub commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

Add support for a document update permission and grant it to loan officers.

New Features:

  • Introduce a dedicated DOCUMENT_UPDATE_PERMISSION flag for document update operations.

Enhancements:

  • Include document update permission in the default attribute set for loan officer users.

@sourcery-ai

sourcery-ai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds support for a new document update permission and ensures loan officers receive this permission in their attribute map.

File-Level Changes

Change Details Files
Introduce a new document update permission constant and propagate it into loan officer attribute initialization.
  • Define a new DOCUMENT_UPDATE_PERMISSION constant alongside existing document-related permissions
  • Set the document update permission to true in the loan officer attributes map so loan officers can update documents
src/main/java/com/loan_org/identity_and_access_management/util/UserAttributeFactory.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@amanfoundongithub amanfoundongithub merged commit fba7435 into main Jun 12, 2026
4 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider centralizing permission strings (e.g., in an enum or dedicated permissions class) rather than adding more standalone constants to reduce the risk of typos and keep the permission set easier to manage.
  • Double-check that the new DOCUMENT_UPDATE_PERMISSION name is consistent with existing terminology (e.g., update vs edit vs modify) across the codebase to avoid confusion when checking permissions.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider centralizing permission strings (e.g., in an enum or dedicated permissions class) rather than adding more standalone constants to reduce the risk of typos and keep the permission set easier to manage.
- Double-check that the new `DOCUMENT_UPDATE_PERMISSION` name is consistent with existing terminology (e.g., `update` vs `edit` vs `modify`) across the codebase to avoid confusion when checking permissions.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant