test(plugins/cgroups): Invert how the manual integration tests work in cgroup plugins#406
Open
victoryeagle77 wants to merge 1 commit into
Open
test(plugins/cgroups): Invert how the manual integration tests work in cgroup plugins#406victoryeagle77 wants to merge 1 commit into
victoryeagle77 wants to merge 1 commit into
Conversation
TheElectronWill
left a comment
TheElectronWill
left a comment
Member
There was a problem hiding this comment.
the CI needs to be updated, it currently uses SKIP_CGROUPFS_TESTS (that can be removed)
victoryeagle77
force-pushed
the
plugins/cgroups
branch
2 times, most recently
from
5afd821 to
3ad997a
Compare
victoryeagle77
force-pushed
the
plugins/cgroups
branch
2 times, most recently
from
aefa70d to
6e34712
Compare
TheElectronWill
requested changes
Jun 8, 2026
| environment: | ||
| # tests that manipulate the cgroupfs don't work in the CI container, because it has no systemd user slice, so the tests cannot create cgroups | ||
| SKIP_CGROUPFS_TESTS: true | ||
| RUN_CGROUPFS_TESTS: true |
Member
There was a problem hiding this comment.
cgroupfs tests must not run in the CI…
victoryeagle77
force-pushed
the
plugins/cgroups
branch
from
6e34712 to
358ebb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.