Tests: enable range_gate in reorder unit test#29
Conversation
…pected NaN gating
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| rclpy.init(args=[ | ||
| '--ros-args', | ||
| '-p', f'config:={str(yaml)}', | ||
| '-p', 'range_gate_enabled:=true', |
There was a problem hiding this comment.
[P1] Range-gate test never drives threshold below default 60 m
The added -p range_gate_enabled:=true still won’t make the assertions below pass, because AiryReorderNode uses the parameters range_min_m/range_max_m (defaults 0.1–60 m) for gating and ignores the range_m values written into this YAML. All sample points are at 2 m, which is well inside the default 60 m window, so even with gating enabled they won’t be NaN’d and the test fails. The test needs to pass -p range_max_m:=1.0 (or the node must read range_m from the config) to actually exercise out-of-range behavior.
Useful? React with 👍 / 👎.
1 participant
Unit test expected NaN gating for out-of-range points, but range_gate is disabled by default. Pass range_gate_enabled:=true in test to make expectation match behavior.