CI: split core vs mapping (non-gating); add nightly mapping#24
Conversation
alpharover
commented
Sep 1, 2025
- Core Build: build/test full workspace skipping alpha_mapping to unblock trunk.\n- Mapping Build: separate job runs on mapping changes and nightly; continue-on-error with log artifact.\n- Adds concurrency to cancel superseded runs and nightly schedule trigger.\n- Re-gate rule: after 7 consecutive green mapping builds (PR/nightly) or 1 week green, restore mapping into Core Build and drop the separate job.
… to avoid build/test gaps; keep rosdep as primary
…SharedInstance usage
…d (paths-filter + nightly); add concurrency
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| - 'deploy/**' | ||
| - '.github/workflows/ci.yml' | ||
| - '!**/*.md' |
There was a problem hiding this comment.
[P1] Provide base/ref for paths-filter on scheduled runs
The workflow now runs on schedule and workflow_dispatch, but the dorny/paths-filter@v3 step still relies on the event payload to determine the diff. For these event types the action does not have a commit range and will fail unless base/ref are provided. Because mapping-build depends on this job, nightly or manually triggered mapping builds will exit at “Detect Changes” before the non‑gating job runs, defeating the purpose of the new scheduled mapping CI.
Useful? React with 👍 / 👎.