alpha_mapping: shared_ptr provider; fix pluginlib instance creation#22
Merged
Conversation
alpharover
commented
Sep 1, 2025
alpharover
commented
Owner
- Switch provider_ to std::shared_ptr.\n- Use loader_->createSharedInstance(plugin_name) to get a shared pointer.\n- Avoid passing shared_ptr to unique_ptr::reset which caused build error.\n\nFixes remaining alpha_mapping build failure in CI.
… to avoid build/test gaps; keep rosdep as primary
…SharedInstance usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.