add burly-tabs-save-current-windows#73
Open
TauPan wants to merge 1 commit into
Open
Conversation
I sometimes change little things in the windows, such as moving point etc. and if I want to keep the current configuration under the existing bookmark, I think this command is handy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I sometimes change little things in the windows, such as moving point etc. and if I want to keep the current configuration under the existing bookmark, I think this command is handy.
I tried to make the simplest change possible on purpose, so this is not DRY.
To make this a bit more DRY, one could factor out the pcase-let with the guard as e.g.
burly-tabs--get-current-bookmark-nameand use it in burly-tabs-reset-tab as well.Minor points:
pcase-let*with star is strictly not necessary, but you may prefer it because it's mostly what one wants with multiple bindings. It probably adds some safety against later code modifications.Also not sure how I feel about the command name.