Skip to content

fix(presence): respect ALLOW_ANON_PRESENCE and enable presence tracking for sessions #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aaravanand00 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(presence): respect ALLOW_ANON_PRESENCE and enable presence tracking for sessions #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6527,13 +6527,22 @@ async def on_fetch(self, request):
user_param = (qs.get("user_id") or [None])[0]
display_param = (qs.get("display_name") or [None])[0]

allow_anon_raw = getattr(self.env, "ALLOW_ANON_PRESENCE", "true")
allow_anon = str(allow_anon_raw).strip().lower() in ("true", "1", "yes")

authenticated_user = verify_token(token_param or "", self.env.JWT_SECRET) if token_param else None
can_interact = authenticated_user is not None

if authenticated_user:
user_id = str(authenticated_user.get("id", ""))
display_name = str(authenticated_user.get("username") or user_id)
can_interact = True
else:
if not allow_anon:
return Response(
json.dumps({"error": "Authentication required"}),
status=401,
headers={"Content-Type": "application/json"},
)
if token_param or not user_param:
return Response(
json.dumps({"error": "Authentication required"}),
Expand All @@ -6542,6 +6551,7 @@ async def on_fetch(self, request):
)
user_id = str(user_param)
display_name = str(display_param or user_id)
can_interact = True

user_id = user_id[:64]
display_name = display_name[:64]
Expand Down