fix: add listen: false to showToolbar() and hideToolbar()#280
Open
nateshmbhat wants to merge 1 commit into
Open
fix: add listen: false to showToolbar() and hideToolbar()#280nateshmbhat wants to merge 1 commit into
nateshmbhat wants to merge 1 commit into
Conversation
Fixes aloisdeniel#278 Added `listen: false` parameter to Provider.of calls in showToolbar() and hideToolbar() methods to prevent assertion errors when called from event handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #278
Adds
listen: falseparameter toProvider.of<DevicePreviewStore>()calls inshowToolbar()andhideToolbar()methods to prevent assertion errors when called from event handlers.Changes
Only two lines changed:
, listen: falsetoshowToolbar()method, listen: falsetohideToolbar()methodWhy This Fix is Needed
Without
listen: false, calling these methods from event handlers (buttononPressed, switchonChanged, etc.) throws:Consistency
This makes both methods consistent with other static methods in the same file like
selectDevice()andavailableDeviceIdentifiers()which already uselisten: false.Testing
Verified with a switch widget calling these methods - no more errors: