Skip to content

🎨 Palette: [UX improvement] Add ARIA labels to playground controls #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aloewright wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🎨 Palette: [UX improvement] Add ARIA labels to playground controls #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7cc539
Add ARIA labels to playground form controls
google-labs-jules[bot] May 27, 2026
7ff5d55
Add ARIA labels to playground form controls
google-labs-jules[bot] May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/quill/client/components/playground-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ export function PlaygroundView({
<div className="mb-6 grid gap-3 md:grid-cols-3">
<Control label="Guide">
<select
aria-label="Guide"
className="pp-select"
Comment on lines +298 to 299

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the <select> element is already nested inside a <label> element (via the <Control> wrapper), it is implicitly associated with the label text "Guide". Adding an explicit aria-label with the exact same text is redundant and can cause some screen readers to double-announce the label (e.g., "Guide, Guide, pop-up button").

Consider removing the redundant aria-label attribute.

Suggested change
aria-label="Guide"
className="pp-select"
className="pp-select"

onChange={(e) => setGuideSlug(e.target.value)}
value={guideSlug}
Expand All @@ -309,6 +310,7 @@ export function PlaygroundView({

<Control label="Preset">
<select
aria-label="Preset"
className="pp-select"
Comment on lines +313 to 314

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the "Guide" control, the <select> element for "Preset" is already nested inside a <label> element via the <Control> wrapper, making it implicitly associated with the label text "Preset". Adding aria-label="Preset" is redundant and can lead to double-announcements in some screen readers.

Consider removing the redundant aria-label attribute.

Suggested change
aria-label="Preset"
className="pp-select"
className="pp-select"

onChange={(e) => setPresetSlug(e.target.value as UseCase | "")}
value={presetSlug}
Expand All @@ -326,6 +328,7 @@ export function PlaygroundView({

<Control label={`Temperature · ${temperature.toFixed(1)}`}>
<input
aria-label="Temperature"
className="w-full"
max="1"
min="0"
Expand Down
Loading