fix: close file handles in read_full_med_mentions and read_ner_from_tsv#624
Open
Chessing234 wants to merge 1 commit into
Open
fix: close file handles in read_full_med_mentions and read_ner_from_tsv#624Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Wrap the id-file and tsv reads in with-statements so the handles are closed deterministically instead of relying on GC. Fixes allenai#599. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scispacy/data_util.pyopened several files without ever closing them:read_full_med_mentions()opened the train/dev/test id files inline in set comprehensions.read_ner_from_tsv()iterated directly overopen(cached_path(filename)).These handles were only released by the garbage collector, which is not deterministic on non-CPython runtimes and leaks descriptors when many files are processed.
Fix
Wrap each read in a
withstatement so the handle is closed as soon as the read completes. Behavior is otherwise unchanged.Fixes #599.
Made with Cursor