fix: use hypernym in which_look_like Hearst pattern#623
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
The which_look_like 'last'-position pattern ended with hyponym instead of hypernym, unlike the structurally identical which_sound_like pattern. Fixes allenai#595. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
scispacy/hearst_patterns.py, thewhich_look_like"last"-position pattern ended withhyponyminstead ofhypernym. Every other"position": "last"pattern (including the structurally identicalwhich_sound_likeright below it) ends withhypernym, so this was a copy-paste slip that made the pattern extract the wrong term as the hypernym.Fix
Change the final token in the
which_look_likepattern fromhyponymtohypernym.Fixes #595.
Made with Cursor