fix: close file handles in read_full_med_mentions and read_ner_from_tsv#612
Open
Chessing234 wants to merge 1 commit into
Open
fix: close file handles in read_full_med_mentions and read_ner_from_tsv#612Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Use context managers when opening ID list files and TSV inputs so file handles are closed promptly instead of relying on GC. Fixes allenai#599. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #599
Summary
read_full_med_mentions()with context managersread_ner_from_tsv()with a context managerTest plan
withstatements and preserve existing behaviorMade with Cursor