fix: typo in CandidateGenerator error and which_look_like Hearst pattern#608
Open
Chessing234 wants to merge 1 commit into
Open
fix: typo in CandidateGenerator error and which_look_like Hearst pattern#608Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
allenai#601, allenai#595) Correct 'constuctor' -> 'constructor' in the ValueError message and use hypernym instead of hyponym in the which_look_like Hearst pattern so the final noun phrase is tagged with the correct role. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constuctor→constructorinCandidateGeneratorValueError message (Fixes fix: typo 'constuctor' → 'constructor' in CandidateGenerator error message #601)which_look_likeHearst pattern: last token should behypernym, nothyponym(Fixes fix: which_look_like Hearst pattern uses hyponym twice instead of hypernym #595)Test plan
CandidateGeneratorraises ValueError with correct spelling when bothnameand other constructor args are passedwhich_look_likepattern matches phrases like "cells which look like fibroblasts" with correct hypernym/hyponym rolesMade with Cursor