fix: typo, file handle leaks, Hearst pattern, and scorer span pairing#607
Open
Chessing234 wants to merge 2 commits into
Open
fix: typo, file handle leaks, Hearst pattern, and scorer span pairing#607Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
Closes allenai#601, allenai#599, allenai#597, allenai#595, and allenai#592. Co-authored-by: Cursor <cursoragent@cursor.com>
Fixes allenai#593. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constuctor→constructorinCandidateGeneratorerror message (Fixes fix: typo 'constuctor' → 'constructor' in CandidateGenerator error message #601)read_full_med_mentions()andread_ner_from_tsv()using context managers (Fixes fix: unclosed file handles in read_full_med_mentions() and read_ner_from_tsv() #599)which_look_likeHearst pattern usinghypernyminstead ofhyponymat the end of the pattern (Fixes fix: which_look_like Hearst pattern uses hyponym twice instead of hypernym #595)PerClassScorercaused byzip(*set(...))(Fixes fix: set-list zip produces incorrect span pairings in PerClassScorer (candidate_generation.py) #592)evaluate_ner()(Fixes fix: unclosed file handle in evaluate_ner() when dumping metrics #597)Test plan
candidate_generation.pywith open(...)indata_util.pywhich_look_likepattern ends withhypernymlike adjacent patternsMade with Cursor