fix: register replace_tokenizer callback on import (Fixes #440)#604
Open
Chessing234 wants to merge 1 commit into
Open
fix: register replace_tokenizer callback on import (Fixes #440)#604Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Imported scispaCy models reference the replace_tokenizer training callback, but it was only registered when base_project_code was loaded for project training. Importing scispacy now registers callbacks so begin_training works. Fixes allenai#440 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #440
scispaCy model configs reference
@callbacks = "replace_tokenizer", but that callback lives inbase_project_code.pyand was only registered during spaCy project training—not on a normalimport scispacy. Callingnlp.begin_training()then fails withRegistryError: Could not find function 'replace_tokenizer'.Import
base_project_codefromscispacy/__init__.pyso the callback is registered whenever scispacy is imported.