fix: shorten dataset cache filenames to avoid NAME_MAX errors#589
Open
Chessing234 wants to merge 1 commit into
Open
fix: shorten dataset cache filenames to avoid NAME_MAX errors#589Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
url_to_filename appended the full URL tail (e.g. tfidf_vectors_sparse.npz) after double sha256 hashes, producing paths over eCryptfs NAME_MAX and raising OSError on cache writes (fixes allenai#539). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #539.
UMLS linker setup fails with
OSError: [Errno 36] File name too longwhen writing cached linker files on filesystems with a low NAME_MAX (e.g. eCryptfs at 143 bytes).Root cause
url_to_filename()appended the full trailing URL component after two sha256 hashes, producing filenames around 155 characters for UMLS assets liketfidf_vectors_sparse.npz.Fix
Keep only the file extension from the URL tail instead of the full basename, so hashed cache paths stay within NAME_MAX while remaining deterministic per URL/etag.
Test plan
url_to_filename()for a UMLS tfidf URL — filename length 133, ends with.npzMade with Cursor