Fix file cache to support offline usage of previously downloaded files#586
Open
Chessing234 wants to merge 1 commit into
Open
Fix file cache to support offline usage of previously downloaded files#586Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Check the local cache before calling requests.head so previously downloaded linker data works offline. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #535
Bug
get_from_cache()always sends an HTTP HEAD request before checking the local cache. After a successful download, loading the linker again fails offline because the HEAD request errors before the cached file is returned.Root cause
get_from_cache()callsrequests.head(url)unconditionally to obtain an ETag and derive the cache filename, even when a matching cached file already exists under~/.scispacy/datasets/.Why this fix is correct
Cached filenames always start with the SHA-256 hash of the URL. Scan the cache directory for an existing file with that prefix and return it before any network call. Fresh downloads still use HEAD to resolve the ETag when no cached file is present.
Made with Cursor