Conversation
AGENTS.md told every mason.py launch script to pass --no_auto_dataset_cache on macOS, because local caching "fails on the `import vllm` in `data_loader.py`". allenai#1866 removed that import, and its own CHANGELOG entry says mason no longer needs the flag for it, but this line was not updated. The blanket rule is now wrong for most entrypoints and still right for two. Local caching re-runs the training entrypoint with --cache_dataset_only, so what matters is whether that module imports vllm. Measured on macOS at b926978: finetune.py imports OK dpo.py imports OK dpo_tune_cache.py imports OK reward_modeling.py imports OK grpo.py ModuleNotFoundError: No module named 'vllm' grpo_fast.py ModuleNotFoundError: No module named 'vllm' grpo_fast.py still imports vllm at module level (vllm.distributed.weight_transfer, line 80) and grpo.py pulls it in through vllm_utils, which imports vllm at line 39. Rewrites the line to scope the flag to GRPO scripts and to say why, so the rule stays checkable as more entrypoints drop the import. Also notes that mason.py only prints a hint on macOS and still attempts caching, so it does not protect you either way. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AGENTS.mdtells everymason.pylaunch script to pass--no_auto_dataset_cacheon macOS:#1866 removed that import. Its own CHANGELOG entry says so:
but this line was not updated alongside it, so the agent instructions now contradict the changelog.
What is actually true now
Local caching re-runs the training entrypoint with
--cache_dataset_only, so what matters is whether that module imports vllm. Measured on macOS at b926978, importing each of the six entries inOPEN_INSTRUCT_COMMANDS:finetune.pydpo.pydpo_tune_cache.pyreward_modeling.pygrpo.pyModuleNotFoundError: No module named 'vllm'grpo_fast.pyModuleNotFoundError: No module named 'vllm'So the blanket rule is now wrong for four of six and still right for two. The two that fail do so for reasons unrelated to
data_loader.py:grpo_fast.py:80—from vllm.distributed.weight_transfer.base import WeightTransferInitRequestgrpo.py:34— importsvllm_utils, which does a plainimport vllmat line 39Change
Scopes the rule to GRPO scripts and states the mechanism, so it stays checkable as more entrypoints drop the import rather than going stale again silently.
It also records something that surprised me while checking:
mason.pydoes not protect you here either way. On macOS it prints a hint and then attempts caching anyway:That message is now over-broad for the same reason the AGENTS.md line was — it fires for
finetune.pyanddpo.pyruns that would cache fine. I leftmason.pyalone to keep this docs-only; narrowing the warning to the GRPO entrypoints would be a reasonable follow-up if you want it.Testing
No code changed. The table above is the verification — each entrypoint imported directly under
uv runon macOS/arm64.Docs only: no files under
open_instruct/, so the CHANGELOG check does not apply and no GPU code paths are touched.GPU_TESTS=bypass
🤖 Generated with Claude Code