Skip to content

fix: handle CDK tokens in ResourcePrefixAspect#1696

Merged
kai-nguyen-aligent merged 2 commits into
mainfrom
fix/MI-323-resource-prefix-aspect-ignore-cdk-token
May 26, 2026
Merged

fix: handle CDK tokens in ResourcePrefixAspect#1696
kai-nguyen-aligent merged 2 commits into
mainfrom
fix/MI-323-resource-prefix-aspect-ignore-cdk-token

Conversation

@kai-nguyen-aligent

@kai-nguyen-aligent kai-nguyen-aligent commented May 26, 2026

Copy link
Copy Markdown
Contributor

Description of the proposed changes

  • Fix ResourcePrefixAspect to gracefully handle CDK tokens (e.g. Fn.ref, Lazy.string) in resource name properties by falling back to the sanitised logical ID instead of using the unresolved token string
  • Add test coverage for both Fn.ref and Lazy.string token scenarios

Other solutions considered

  • Resolving tokens at aspect-visit time was considered but rejected since tokens may not be resolvable during the aspect pass

Notes to reviewers

  • 🛈 Toggl Code: MI-323: Code Review
  • 🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

@kai-nguyen-aligent kai-nguyen-aligent marked this pull request as ready for review May 26, 2026 01:53
@kai-nguyen-aligent kai-nguyen-aligent requested a review from a team as a code owner May 26, 2026 01:53

@aaronmedina-dev aaronmedina-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kai-nguyen-aligent kai-nguyen-aligent merged commit f6cbd26 into main May 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants