Skip to content

fix: improve test isolation in graphql-mesh-server maintenance tests #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-vdp merged 2 commits into from
Jul 23, 2025
Merged

fix: improve test isolation in graphql-mesh-server maintenance tests #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa4f05e
fix: improve test isolation in graphql-mesh-server maintenance tests
Jul 22, 2025
ecc4971
fix: improve file cleanup and test isolation in maintenance tests
Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion packages/graphql-mesh-server/assets/handlers/maintenance/maintenance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,15 @@ const createMockEvent = (
const mockSites = { "example.com": false, "example.com.au": false };

describe("Lambda handler", () => {
beforeAll(() => {
beforeEach(() => {
// Clean up any existing maintenance files before each test
if (existsSync(`${cwd()}/maintenance.enabled`)) {
rmSync(`${cwd()}/maintenance.enabled`);
}
if (existsSync(`${cwd()}/maintenance.disabled`)) {
rmSync(`${cwd()}/maintenance.disabled`);
}
// Reset the maintenance status before each test to ensure test isolation
updateMaintenanceStatus(mockSites);
});

Expand All @@ -51,7 +59,17 @@ describe("Lambda handler", () => {
});

it("should handle POST'ing a disable all sites", async () => {
// First enable a site to set up the required state
const enableUpdate = {
sites: { "example.com": false, "example.com.au": true },
};
const enableEvent = createMockEvent("POST", JSON.stringify(enableUpdate));
await handler(enableEvent);

// Verify the file is in enabled state as expected
expect(existsSync(`${cwd()}/maintenance.enabled`)).toBe(true);

// Now test disabling all sites
const mockUpdate = {
sites: { "example.com": false, "example.com.au": false },
};
Expand Down
10 changes: 9 additions & 1 deletion packages/graphql-mesh-server/assets/handlers/maintenance/whitelist.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,15 @@ const mockAllowlist = [
"2001:4860:4860::8888", // Google DNS IPv6
];
describe("Lambda handler", () => {
beforeAll(() => {
beforeEach(() => {
// Clean up any existing maintenance files before each test
if (existsSync(`${cwd()}/maintenance.enabled`)) {
rmSync(`${cwd()}/maintenance.enabled`);
}
if (existsSync(`${cwd()}/maintenance.disabled`)) {
rmSync(`${cwd()}/maintenance.disabled`);
}
// Reset the whitelist before each test to ensure test isolation
setWhitelist(mockAllowlist);
});

Expand Down