Add multi site support#1487
Merged
Merged
Conversation
…P address allow list
…with which sites should in / out of maint mode
…e root POST method now.
AdamJHall
requested review from
aaronmedina-dev,
crispy101,
daniel-vdp,
hubertott and
porhkz
aaronmedina-dev
approved these changes
May 26, 2025
aaronmedina-dev
left a comment
aaronmedina-dev
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Did not see any syntax error/issue.
High-level assessment of the conditions and code structure looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This PR updates the whitelist API, maintenance mode API and maintenance file to use JSON so that the API and mesh can support having individual sites in / out of maintenance mode without affecting the others.
Other solutions considered (if any)
I considered using multiple files with a "website scope code" e.g.
maintenance.au.enabledbut I think that will get a bit difficult to use as site counts grow.Notes to PR author
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback