Skip to content

[tests] Apply PEP8 linting#3124

Open
cbentejac wants to merge 4 commits into
developfrom
linting/tests
Open

[tests] Apply PEP8 linting#3124
cbentejac wants to merge 4 commits into
developfrom
linting/tests

Conversation

@cbentejac
Copy link
Copy Markdown
Contributor

@cbentejac cbentejac commented Jun 5, 2026

Description

This PR applies PEP8 linting to the tests module and fixes the following issues:

  • E302: expected 2 blank lines, found 1.
  • W292: no newline at end of file.
  • E128: continuation line under-indented for visual indent.
  • E251: unexpected spaces around keyword / parameter equals.
  • W293: blank line contains whitespace.
  • F541: f-string is missing placeholders.
  • E261: at least two spaces before inline comment.
  • E712: comparison to True should be 'if cond is True:' or 'if cond'.
  • E303: too many blank lines.
  • E711: comparison to None should be 'if cond is None'.
  • E222: multiple spaces after operator.
  • E225: missing whitespace around operator.
  • E306: expected 1 blank line before a nested definition, found 0.
  • E301: expected 1 blank line, found 0.
  • W291: trailing whitespaces.
  • F401: 'xxx' imported but not used.
  • W391: blank line at end of file.
  • F841: local 'var' assigned to but never used.
  • E275: missing whitespace after keyword.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs code formatting, whitespace cleanup, and simplifies boolean assertions across several test files. The review feedback highlights a few issues in the test files, including a copy-paste error in NestedTest.py where the parameter 'y' is incorrectly labeled as 'z', a docstring mismatch in PluginSubmitter.py where PluginSubmitterA1 is described as having a dynamic node size despite using a static one, and a minor typo in another docstring.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/nodes/test/NestedTest.py Outdated
Comment thread tests/plugins/meshroom/pluginSubmitter/PluginSubmitter.py Outdated
Comment thread tests/plugins/meshroom/pluginSubmitter/PluginSubmitter.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

❌ Patch coverage is 93.84615% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.38%. Comparing base (dc21cee) to head (88e4291).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lugins/meshroom/pluginSubmitter/PluginSubmitter.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3124      +/-   ##
===========================================
- Coverage    85.38%   85.38%   -0.01%     
===========================================
  Files           73       73              
  Lines        11406    11404       -2     
===========================================
- Hits          9739     9737       -2     
  Misses        1667     1667              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac force-pushed the linting/tests branch 2 times, most recently from afdd441 to 12c5640 Compare June 5, 2026 14:38
@cbentejac cbentejac marked this pull request as ready for review June 5, 2026 14:45
@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone Jun 5, 2026
@cbentejac cbentejac self-assigned this Jun 5, 2026
Comment thread tests/nodes/test/Color.py Outdated
Comment thread tests/nodes/test/NestedTest.py Outdated
Comment thread tests/nodes/test/Position.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants