Skip to content

Add nightly build workflow for Windows and Linux#2132

Open
fabiencastan wants to merge 1 commit into
developfrom
ci/nightly
Open

Add nightly build workflow for Windows and Linux#2132
fabiencastan wants to merge 1 commit into
developfrom
ci/nightly

Conversation

@fabiencastan
Copy link
Copy Markdown
Member

@fabiencastan fabiencastan commented Jun 5, 2026

Description

This workflow runs nightly builds for both Windows and Linux binaries, checking for new commits on the develop branch and updating the nightly release with new artifacts.

Features list

  • Create and update a nightly draft-release

Implementation remarks

  • Modification to src/cmake/MakeBundle.cmake‎: GNUInstallDirs cannot be used in a cmake script (called with cmake -P), so we compute the various paths manually.

This PR is similar to the PR on Meshroom: alicevision/Meshroom#3121

@fabiencastan fabiencastan added scope:build scope:ci deploying Anything related to deploying (packaging etc) labels Jun 5, 2026
@fabiencastan fabiencastan added this to the 3.4.0 milestone Jun 5, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the bundle creation process in CMake. It introduces the ALICEVISION_BUNDLE_SEARCH_LIBS_PATHS option to search for external libraries, resolves VCPKG directories explicitly based on the build type, and scans CMAKE_PREFIX_PATH for library paths. Additionally, MakeBundle.cmake is updated with parameter validation, manual replication of GNUInstallDirs for script mode, and improved directory existence checks. A critical typo was found in src/cmake/MakeBundle.cmake where LIBS_LOOKUPS_PATH is used instead of LIBS_LOOKUPS_PATHS, which prevents the .../lib64 path from being appended on non-Windows systems.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/cmake/MakeBundle.cmake Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploying Anything related to deploying (packaging etc) scope:build scope:ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant