Skip to content

add defaultVariables options to initialize properties#187

Open
binyar wants to merge 2 commits into
alibaba:masterfrom
binyar:messageformat
Open

add defaultVariables options to initialize properties#187
binyar wants to merge 2 commits into
alibaba:masterfrom
binyar:messageformat

Conversation

@binyar

@binyar binyar commented Jun 27, 2022

Copy link
Copy Markdown

In my project, there will be a lot of the same local app data variabls:
e.g

{
"a": "Hello,{appName}",
"b": "Hi,{appName}",
"c": "Good well,{appName}",
...
}

JS code (Before)

// file1
Intl.get('a',{appName:'wahaha'});
// file2
Intl.get('b',{appName:'wahaha'});
// file3
Intl.get('c',{appName:'wahaha'});

JS code(After)

intl.init({
 ...
defaultVariables:{
 appName:"wahaha"
}
})
// file1
Intl.get('a');
// file2
Intl.get('b');
// file3
Intl.get('c');

I want to use a default variables to avoid generating a lot of duplicate code

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


fanmd seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cwtuan

cwtuan commented Jul 4, 2022

Copy link
Copy Markdown
Collaborator

please add some test cases.

@binyar

binyar commented Aug 16, 2022

Copy link
Copy Markdown
Author

please add some test cases.

hi bro, maybe you can have a look at of this,I will use the feature plz.

@cwtuan

cwtuan commented Aug 19, 2022

Copy link
Copy Markdown
Collaborator

Please don't include personal or compony information in the test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants