feat: enhance token usage resolution for OpenAI and Anthropic compati…#223
Open
AlapinEnjoyer wants to merge 1 commit into
Open
feat: enhance token usage resolution for OpenAI and Anthropic compati…#223AlapinEnjoyer wants to merge 1 commit into
AlapinEnjoyer wants to merge 1 commit into
Conversation
Comment on lines
+45
to
+46
| "usage.prompt_tokens_details.cache_creation_tokens", | ||
| "data.usage.prompt_tokens_details.cache_creation_tokens", |
Contributor
There was a problem hiding this comment.
Minor maintainability issue: These two new entries lack comments describing which providers or API formats use cache_creation_tokens under prompt_tokens_details. All other entries in these path lists have explanatory comments. Adding a comment (e.g., // OpenAI-compatible providers or similar) would keep the style consistent and help future maintainers understand when this path applies.
Suggestion:
Suggested change
| "usage.prompt_tokens_details.cache_creation_tokens", | |
| "data.usage.prompt_tokens_details.cache_creation_tokens", | |
| "usage.prompt_tokens_details.cache_creation_tokens", // OpenAI-compatible providers | |
| "data.usage.prompt_tokens_details.cache_creation_tokens", // wrapped OpenAI-compatible providers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cached token usage was not getting tracked for the OpenAI provider, the MR adds a way to recognize the common OpenAI-compatible cached-token fields for custom providers
Type of Change
How Has This Been Tested?
make testpasses locallyTested with a custom provider run
Checklist
go fmt,go vet)