ci: run OCR models in one review job#190
Conversation
| env: | ||
| OCR_LLM_MODELS: ${{ env.OCR_LLM_MODELS }} |
There was a problem hiding this comment.
This step-level env declaration is redundant because job-level env variables are automatically inherited by all steps, including actions/github-script. More importantly, if the job-level OCR_LLM_MODELS variable is ever renamed or removed, ${{ env.OCR_LLM_MODELS }} will silently evaluate to an empty string, causing the script to process zero models with no visible error.
Consider removing this redundant env block entirely (the job-level env is sufficient), or referencing the variable directly via ${{ vars.OCR_LLM_MODELS || 'glm-5.2-fp8 kimi-k2.7-code' }} to preserve the default fallback and make the dependency explicit.
|
|
Summary
OCR / reviewValidation
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ocr-review.yml")'node --check /tmp/ocr-post-script.jsactionlint .github/workflows/ocr-review.yml