Skip to content

fix(proxy): block cookie header in WebSocket forwarding#894

Merged
Issac-Newton merged 1 commit into
alibaba:masterfrom
Issac-Newton:fix/websocket-origin-proxy-spec
Apr 24, 2026
Merged

fix(proxy): block cookie header in WebSocket forwarding#894
Issac-Newton merged 1 commit into
alibaba:masterfrom
Issac-Newton:fix/websocket-origin-proxy-spec

Conversation

@Issac-Newton

Copy link
Copy Markdown
Collaborator

Cookie headers from upstream gateways contain SSO tokens and can be oversized, causing 502 when forwarded to downstream WebSocket services.

close #865

@Issac-Newton Issac-Newton force-pushed the fix/websocket-origin-proxy-spec branch 3 times, most recently from d6c04bf to 54796e3 Compare April 24, 2026 02:22
…switch

- Add forward_ws_headers bool to websocket_proxy() — VNC route sets it
  to False to avoid exceeding QEMU's 4KB header buffer limit
- Update proxy-enhancements spec docs to reflect current implementation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Issac-Newton Issac-Newton force-pushed the fix/websocket-origin-proxy-spec branch from 54796e3 to f78a86b Compare April 24, 2026 02:55

@StephenRi StephenRi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Issac-Newton Issac-Newton merged commit de07eed into alibaba:master Apr 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(proxy): WebSocket proxy loses Origin and auth headers during upstream handshake

2 participants