fix(metrics): exclude BadRequestRockError from request.failure metrics (#1138)#1139
Open
jake11-oho wants to merge 1 commit into
Open
fix(metrics): exclude BadRequestRockError from request.failure metrics (#1138)#1139jake11-oho wants to merge 1 commit into
jake11-oho wants to merge 1 commit into
Conversation
BadRequestRockError (client 4xxx errors) was being counted in request.failure alongside server errors, polluting failure alerting. Route client errors to a separate request.client_error counter so request.failure only reflects genuine server-side failures. fixes alibaba#1138 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request.client_errormetric counter to separately trackBadRequestRockError(client 4xxx errors)_record_metricsto routeBadRequestRockErrorto.client_errorinstead of.failureInternalServerRockError, genericException, etc.) continue to go to.failurefixes #1138
Test plan
test_record_metrics_bad_request_goes_to_client_error— verifiesBadRequestRockErrorgoes to.client_error, NOT.failuretest_record_metrics_server_error_goes_to_failure— verifiesInternalServerRockErrorstill goes to.failure🤖 Generated with Claude Code