Skip to content

feat(sandbox): add /delete endpoint + STOPPED → DELETED for --rm containers#1038

Merged
zhangjaycee merged 1 commit into
alibaba:masterfrom
zhangjaycee:feature/delete
Jun 3, 2026
Merged

feat(sandbox): add /delete endpoint + STOPPED → DELETED for --rm containers#1038
zhangjaycee merged 1 commit into
alibaba:masterfrom
zhangjaycee:feature/delete

Conversation

@zhangjaycee

Copy link
Copy Markdown
Collaborator

close #1032

@zhangjaycee
zhangjaycee force-pushed the feature/delete branch 3 times, most recently from bcb0b47 to b901aff Compare May 29, 2026 10:22
@zhangjaycee
zhangjaycee marked this pull request as ready for review May 29, 2026 10:23
@zhangjaycee
zhangjaycee force-pushed the feature/delete branch 4 times, most recently from acb41a3 to 6a23ae3 Compare June 3, 2026 08:21
@zhangjaycee zhangjaycee changed the title feat(sandbox): add /delete endpoint + auto-delete background scan feat(sandbox): add /delete endpoint + STOPPED → DELETED for --rm containers Jun 3, 2026

@StephenRi StephenRi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…-rm containers

Add a DELETE /sandbox/{id} endpoint that transitions STOPPED sandboxes
to DELETED state, cleaning up containers and archiving metadata.

When `remove_container=True`, the stop flow cascades directly to DELETED
via DeleteReason.IMMEDIATE — the container is already gone after
operator.stop, so we skip the intermediate STOPPED state entirely.
@zhangjaycee
zhangjaycee merged commit 215b118 into alibaba:master Jun 3, 2026
6 of 7 checks passed
jake11-oho pushed a commit to jake11-oho/ROCK that referenced this pull request Jun 10, 2026
…-rm containers (alibaba#1038)

Add a DELETE /sandbox/{id} endpoint that transitions STOPPED sandboxes
to DELETED state, cleaning up containers and archiving metadata.

When `remove_container=True`, the stop flow cascades directly to DELETED
via DeleteReason.IMMEDIATE — the container is already gone after
operator.stop, so we skip the intermediate STOPPED state entirely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support sandbox delete and auto-delete background scan

2 participants