Skip to content

chore(lint): enforce declaration-guard spacing and set Prettier to 100 columns - #107

Merged
aliasunder merged 2 commits into
mainfrom
worktree-lint-spacing-print-width
Sep 24, 2026
Merged

aliasunder merged 2 commits into
mainfrom
worktree-lint-spacing-print-width

Conversation

@aliasunder

@aliasunder aliasunder commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

Adds a lint rule that keeps each declaration visually separate from the if that consumes it, and sets Prettier to 100 columns.

Changes

  • @stylistic/padding-line-between-statements (prev: [const, let], next: if) as an error. --fix added the blank line at 116 sites. Prettier does not manage blank lines, so the two tools cannot conflict.

  • printWidth: 100 in .prettierrc.json, replacing Prettier's implicit 80-column default. Long descriptive names stop wrapping, and lines still fit a side-by-side diff. The whole repo is reformatted.

  • @stylistic/eslint-plugin 5.10.0 added as a dev dependency. ESLint 10 no longer ships the core padding-line-between-statements rule.

  • AGENTS.md → Code style gains the blank-line convention the new rule enforces part of.

  • orchestrate.ts readability cleanup: three comments rewritten as plain sentences, the anchor-stripping regex named and documented, and the rename check's fromPath !== undefined replaced with a truthy guard.

No behavior changes. The diff is formatting, the new config, and the cleanup above.

Verification

  • npm test: 732 passed
  • npm run lint: clean
  • npm run build: clean
  • npx prettier --check .: clean

Merge order

Other open branches that touch src/ will conflict mechanically with the reformat. Rebase each onto this change and rerun npm run lint:fix and npm run prettier to resolve.

🤖 Generated with Claude Code

@socket-security

socket-security Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​stylistic/​eslint-plugin@​5.10.01001007590100

View full report

@umm-actually

umm-actually Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

umm-actually re-reviewed at 6eb48e9

No new findings (1 tracked finding(s) across all runs).

Context notes
  • 1 changed file(s) excluded from review: package-lock.json (built-in default list)

umm-actually · deepseek/deepseek-v4-flash-0731

Comment thread src/orchestrate.ts
@aliasunder
aliasunder force-pushed the worktree-lint-spacing-print-width branch from 83ffb45 to 6eb48e9 Compare September 24, 2026 22:39
@aliasunder
aliasunder merged commit ccef259 into main Sep 24, 2026
9 checks passed
@aliasunder
aliasunder deleted the worktree-lint-spacing-print-width branch September 24, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant