chore(lint): enforce declaration-guard spacing and set Prettier to 100 columns - #107
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
umm-actually re-reviewed at No new findings (1 tracked finding(s) across all runs). Context notes
umm-actually · deepseek/deepseek-v4-flash-0731 |
aliasunder
force-pushed
the
worktree-lint-spacing-print-width
branch
from
September 24, 2026 22:39
83ffb45 to
6eb48e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a lint rule that keeps each declaration visually separate from the
ifthat consumes it, and sets Prettier to 100 columns.Changes
@stylistic/padding-line-between-statements(prev: [const, let],next: if) as an error.--fixadded the blank line at 116 sites. Prettier does not manage blank lines, so the two tools cannot conflict.printWidth: 100in.prettierrc.json, replacing Prettier's implicit 80-column default. Long descriptive names stop wrapping, and lines still fit a side-by-side diff. The whole repo is reformatted.@stylistic/eslint-plugin5.10.0 added as a dev dependency. ESLint 10 no longer ships the corepadding-line-between-statementsrule.AGENTS.md→ Code style gains the blank-line convention the new rule enforces part of.orchestrate.tsreadability cleanup: three comments rewritten as plain sentences, the anchor-stripping regex named and documented, and the rename check'sfromPath !== undefinedreplaced with a truthy guard.No behavior changes. The diff is formatting, the new config, and the cleanup above.
Verification
npm test: 732 passednpm run lint: cleannpm run build: cleannpx prettier --check .: cleanMerge order
Other open branches that touch
src/will conflict mechanically with the reformat. Rebase each onto this change and rerunnpm run lint:fixandnpm run prettierto resolve.🤖 Generated with Claude Code