Skip to content

feat(rename): a rename keeps the file's extension - #3

Merged
algometrix merged 1 commit into
mainfrom
feat/rename-keeps-extension
Nov 18, 2026
Merged

algometrix merged 1 commit into
mainfrom
feat/rename-keeps-extension

Conversation

@algometrix

Copy link
Copy Markdown
Owner

Problem

Renaming a download let you change its extension, so a .mp4 could be saved as .txt by mistake.

What changes

  • The rename box holds only the name. The extension shows as a label beside it and cannot be edited.
  • The core keeps the extension too, whatever asks for the rename. Typing Holiday.mkv for an .mp4 file gives Holiday.mkv.mp4.
  • A download that has not saved its file yet stores only the chosen name. Its extension is still a guess (for example get), so the server's name or the stream container decides it when the file is saved. The dialog says so instead of showing an extension.
  • Names from the user, the browser, or the server count as final and show their extension as usual.

Behavior changes

  • Renaming a download that has not started no longer moves it to another category. It is filed by its real extension.
  • Lists saved by older versions still load: a pending whole name becomes its name without the extension. Older versions cannot read a list saved by this one.

Validation

  • cargo test --workspace: 359 passed.
  • cargo clippy --workspace --all-targets -- -D warnings and cargo fmt --check: clean.
  • New tests: a finished rename keeps the extension, a name chosen before the server answered takes the server's extension, and a whole name saved by an older version keeps the file's extension.
  • Not covered by a test: renaming a download that is running but has not reserved its file. It uses the same finish step as the tested not-started case.
  • The Downpour window was not opened; the dialog layout was checked in a sibling build.

🤖 Generated with Claude Code

The rename box now holds only the name. The extension shows beside it
and cannot change. The core enforces this too: a typed ".mkv" stays part
of the name, and the file keeps its own extension.

A download that has not saved its file yet only stores the chosen name.
The real extension comes from the server's name or the stream container
when the file is saved, so a guessed one is never locked in.

Lists saved by older versions still load: a pending whole name becomes
its name without the extension. Older versions cannot read lists saved
by this one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@algometrix
algometrix merged commit 5082dc7 into main Nov 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant