Repository navigation
feat(rename): a rename keeps the file's extension - #3
Merged
Merged
Conversation
The rename box now holds only the name. The extension shows beside it and cannot change. The core enforces this too: a typed ".mkv" stays part of the name, and the file keeps its own extension. A download that has not saved its file yet only stores the chosen name. The real extension comes from the server's name or the stream container when the file is saved, so a guessed one is never locked in. Lists saved by older versions still load: a pending whole name becomes its name without the extension. Older versions cannot read lists saved by this one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Renaming a download let you change its extension, so a
.mp4could be saved as.txtby mistake.What changes
Holiday.mkvfor an.mp4file givesHoliday.mkv.mp4.get), so the server's name or the stream container decides it when the file is saved. The dialog says so instead of showing an extension.Behavior changes
Validation
cargo test --workspace: 359 passed.cargo clippy --workspace --all-targets -- -D warningsandcargo fmt --check: clean.🤖 Generated with Claude Code