Skip to content

feat(list): usual Windows shortcuts for picking downloads - #2

Merged
algometrix merged 2 commits into
mainfrom
feat/windows-list-keys
Nov 18, 2026
Merged

algometrix merged 2 commits into
mainfrom
feat/windows-list-keys

Conversation

@algometrix

@algometrix algometrix commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

What changes

The download list now supports the usual Windows shortcuts for picking downloads, on top of Ctrl+click and Shift+click:

Keys Does
Ctrl+A Pick every row shown
Shift+↑ / Shift+↓ Extend the pick from the last click
Home / End Go to the first or last row
Shift+Home / Shift+End Extend the pick to the first or last row
Ctrl+Shift+click Add a run to the pick, keeping the rest
Ctrl+C Copy the picked addresses, one per line
  • The row a key goes to scrolls into view.
  • Ctrl+A keeps the anchor of a Shift run, so a later Shift+arrow redraws the run from it, as Explorer does.
  • If text in a label is selected (for example part of an address in the details panel), Ctrl+C copies that text instead.
  • The existing keys are unchanged: ↑/↓ move, Ctrl+↑/↓ reorder within a queue, C copies, Del removes, Esc clears.

Also fixed

  • CI failed in restarting_cleans_waiting_names_but_not_typed_or_finished_ones. The cause: after shutdown, the manager's periodic saver could still write, and on a slower machine it wrote the old list over the one a restarted manager had just saved. shutdown now closes the manager under the save lock after its final save, so later saves write nothing. The new test a_manager_saves_nothing_after_shutdown fails without this fix.

Validation

  • cargo fmt --all --check: clean
  • cargo clippy --workspace --all-targets: clean
  • cargo test --workspace: 362 passed (new tests for the key bindings, the copy event, Ctrl+Shift ranges, Ctrl+A and the closed manager)

Not verified

  • Not tried by hand in Downpour's window. The key handling is covered by unit tests only.

🤖 Generated with Claude Code

algometrix and others added 2 commits November 15, 2026 18:29
- Ctrl+A picks every shown row.
- Shift+Up/Down and Shift+Home/End extend the pick from the last click;
  Home/End go to the first or last row. The row a key goes to scrolls
  into view.
- Ctrl+Shift+click adds a run and keeps the rest.
- Ctrl+C copies the picked addresses, one per line, unless text in a
  label is selected: then it copies that text, as usual.
- Ctrl+A keeps the anchor of a Shift run, as Explorer does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The periodic saver could still write after `shutdown` made its final
save. When another manager opened the same store (as in the restart
test, or an app restart in the same process), that late save wrote the
old list over the new one, so `restarting_cleans_waiting_names...`
failed on slower CI machines.

`shutdown` now closes the manager under the save lock after its final
save, and later saves write nothing. A new test shows the late write
without the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@algometrix
algometrix merged commit 797e12f into main Nov 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant