Repository navigation
feat(list): usual Windows shortcuts for picking downloads - #2
Merged
Merged
Conversation
- Ctrl+A picks every shown row. - Shift+Up/Down and Shift+Home/End extend the pick from the last click; Home/End go to the first or last row. The row a key goes to scrolls into view. - Ctrl+Shift+click adds a run and keeps the rest. - Ctrl+C copies the picked addresses, one per line, unless text in a label is selected: then it copies that text, as usual. - Ctrl+A keeps the anchor of a Shift run, as Explorer does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The periodic saver could still write after `shutdown` made its final save. When another manager opened the same store (as in the restart test, or an app restart in the same process), that late save wrote the old list over the new one, so `restarting_cleans_waiting_names...` failed on slower CI machines. `shutdown` now closes the manager under the save lock after its final save, and later saves write nothing. A new test shows the late write without the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The download list now supports the usual Windows shortcuts for picking downloads, on top of Ctrl+click and Shift+click:
Also fixed
restarting_cleans_waiting_names_but_not_typed_or_finished_ones. The cause: aftershutdown, the manager's periodic saver could still write, and on a slower machine it wrote the old list over the one a restarted manager had just saved.shutdownnow closes the manager under the save lock after its final save, so later saves write nothing. The new testa_manager_saves_nothing_after_shutdownfails without this fix.Validation
cargo fmt --all --check: cleancargo clippy --workspace --all-targets: cleancargo test --workspace: 362 passed (new tests for the key bindings, the copy event, Ctrl+Shift ranges, Ctrl+A and the closed manager)Not verified
🤖 Generated with Claude Code